Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVX-6966: Append to user agent #263

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Conversation

superchilled
Copy link
Contributor

Description

This PR does the following:

  • Updates the README.md file to:
    • Provide guidance on appending a custom string to the User-Agent header

Motivation and Context

We need to add the ability to append to the user agent in the OpenTok SDKs. This is so the partner's team can track usage.

The Ruby SDK already provides this functionality, but it wasn't previously documented in the README. This PR fixes that.

How Has This Been Tested?

There is already a unit test for this behaviour.

Example Output or Screenshots (if appropriate):

n/a

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@superchilled superchilled merged commit c43b8ac into dev Jun 19, 2023
@superchilled superchilled deleted the devx-6966-append-to-user-agent branch June 19, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants